Re: [PATCH 6/6] Staging: iio: adis16209: Use sign_extend32 and adjust a switch statement

[Shreeya Patel]

On Sat, 2018-03-03 at 16:05 +0000, Jonathan Cameron wrote:
> On Fri,ÂÂ2 Mar 2018 19:04:49 +0530
> Shreeya Patel <shreeya.patel23498@xxxxxxxxx> wrote:
> 
> > 
> > Use sign_extend32 function instead of manually coding it.
> > Also, adjust a switch block to explicitly match channels
> > and return -EINVAL as default case which makes the code
> > semantically more clear.
> > 
> > Signed-off-by: Shreeya Patel <shreeya.patel23498@xxxxxxxxx>
> Changes are fine, but 2 changes to different things should be
> in 2 patches.ÂÂPlease split. I'd probably have taken this anyway if
> it hadn't been queued behind the requested changes to the previous 2
> patches anyway.
> 
> Good work on this series though so looking forward to v3.Â
> Note please mark the set as [PATCH v3] to make it clear it
> is the 3rd version of some of this.

Yes, I'll do the changes.

Do I need to include the patches which have been merged from
this series in v3?Â

Thanks
> 
> > 
> > ---
> > Âdrivers/staging/iio/accel/adis16209.c | 15 ++++++++++-----
> > Â1 file changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/accel/adis16209.c
> > b/drivers/staging/iio/accel/adis16209.c
> > index 7363fd0..5ab44a4 100644
> > --- a/drivers/staging/iio/accel/adis16209.c
> > +++ b/drivers/staging/iio/accel/adis16209.c
> > @@ -150,10 +150,16 @@ static int adis16209_read_raw(struct iio_dev
> > *indio_dev,
> > Â		switch (chan->type) {
> > Â		case IIO_VOLTAGE:
> > Â			*val = 0;
> > -			if (chan->channel == 0)
> > +			switch (chan->channel) {
> > +			case 0:
> > Â				*val2 = 305180; /* 0.30518 mV */
> > -			else
> > +				break;
> > +			case 1:
> > Â				*val2 = 610500; /* 0.6105 mV */
> > +				break;
> > +			default:
> > +				return -EINVAL;
> > +			}
> > Â			return IIO_VAL_INT_PLUS_MICRO;
> > Â		case IIO_TEMP:
> > Â			*val = -470;
> > @@ -197,9 +203,8 @@ static int adis16209_read_raw(struct iio_dev
> > *indio_dev,
> > Â		ret = adis_read_reg_16(st, addr, &val16);
> > Â		if (ret)
> > Â			return ret;
> > -		val16 &= (1 << bits) - 1;
> > -		val16 = (s16)(val16 << (16 - bits)) >> (16 -
> > bits);
> > -		*val = val16;
> > +
> > +		*val = sign_extend32(val16, bits - 1);
> > Â		return IIO_VAL_INT;
> > Â	}
> > Â	return -EINVAL;