Re: [PATCH v3 15/16] mmc: tmio: clear force_pio flag before starting data transfer

[Wolfram Sang]

On Thu, Jan 18, 2018 at 01:28:15AM +0900, Masahiro Yamada wrote:
> Currently, force_pio is cleared when the driver exits.  Then, it
> resulted in clearing it in multiple places since MMC drivers in
> general have multiple exit points.
> 
>  tmio_mmc_reset_work - bails out on timeout
>  tmio_process_mrq - error out when it cannot send a command
>  tmio_mmc_finish_request - successful exit
> 
> This is error-prone since we may miss to cover all bail-out points.
> 
> To simplify the code, the data structure should be initialized just
> before used since we have a single entrance.  force_pio is only used
> for data transfer, so tmio_mmc_start_data() will be a suitable place
> to clear this flag.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature