Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer
From: David Miller
Date: Sun Mar 04 2018 - 22:17:04 EST
From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Mon, 5 Mar 2018 10:43:41 +0800
>
>
> On 2018年03月05日 07:38, David Miller wrote:
>> From: Jason Wang <jasowang@xxxxxxxxxx>
>> Date: Fri, 2 Mar 2018 17:29:14 +0800
>>
>>> XDP_REDIRECT support for mergeable buffer was removed since commit
>>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
>>> case"). This is because we don't reserve enough tailroom for struct
>>> skb_shared_info which breaks XDP assumption. So this patch fixes this
>>> by reserving enough tailroom and using fixed size of rx buffer.
>>>
>>> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
>>> ---
>>> Changes from V1:
>>> - do not add duplicated tracepoint when redirection fails
>> Applied to net-next, thanks Jason.
>
> Hi David,
>
> Consider the change is not large, any chance to make it for -net to
> keep XDP redirection work?
Ok, I'll apply this to 'net' too.