Re: [PATCH v2 2/4] rtc: isl1208: switch to rtc_register_device

[Denis OSTERLAND]

Hi,

an obvious mistake by me.
isl1208 is introduced in patch 3/4.
I will send v3.
Sorry for that.

Regards Denis

Am Samstag, den 03.03.2018, 10:35 +0800 schrieb kbuild test robot:
> Hi Denis,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on abelloni/rtc-next]
> [also build test ERROR on v4.16-rc3 next-20180302]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:ÂÂÂÂhttps://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-and-isl1219-support/20180303-093405
> base:ÂÂÂhttps://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
> config: x86_64-randconfig-x017-201808 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> ÂÂÂÂÂÂÂÂ# save the attached .config to linux build tree
> ÂÂÂÂÂÂÂÂmake ARCH=x86_64Â
> 
> Note: the linux-review/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-and-isl1219-support/20180303-093405 HEAD 1d3cf882ecd061847968da1511ec956b9bf70d33 builds fine.
> ÂÂÂÂÂÂIt only hurts bisectibility.
> 
> All error/warnings (new ones prefixed by >>):
> 
> ÂÂÂIn file included from drivers/rtc/rtc-isl1208.c:16:0:
> ÂÂÂdrivers/rtc/rtc-isl1208.c: In function 'isl1208_probe':
> > 
> > > 
> > > drivers/rtc/rtc-isl1208.c:677:29: error: 'isl1208' undeclared (first use in this function)
> ÂÂÂÂÂreturn rtc_register_device(isl1208->rtc);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> ÂÂÂinclude/linux/rtc.h:261:37: note: in definition of macro 'rtc_register_device'
> ÂÂÂÂÂ__rtc_register_device(THIS_MODULE, device)
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^~~~~~
> ÂÂÂdrivers/rtc/rtc-isl1208.c:677:29: note: each undeclared identifier is reported only once for each function it appears in
> ÂÂÂÂÂreturn rtc_register_device(isl1208->rtc);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> ÂÂÂinclude/linux/rtc.h:261:37: note: in definition of macro 'rtc_register_device'
> ÂÂÂÂÂ__rtc_register_device(THIS_MODULE, device)
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^~~~~~
> > 
> > > 
> > > drivers/rtc/rtc-isl1208.c:678:1: warning: control reaches end of non-void function [-Wreturn-type]
> ÂÂÂÂ}
> ÂÂÂÂ^
> 
> vim +/isl1208 +677 drivers/rtc/rtc-isl1208.c
> 
> ÂÂÂ625	
> ÂÂÂ626	static int
> ÂÂÂ627	isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
> ÂÂÂ628	{
> ÂÂÂ629		int rc = 0;
> ÂÂÂ630		struct rtc_device *rtc;
> ÂÂÂ631	
> ÂÂÂ632		if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
> ÂÂÂ633			return -ENODEV;
> ÂÂÂ634	
> ÂÂÂ635		if (isl1208_i2c_validate_client(client) < 0)
> ÂÂÂ636			return -ENODEV;
> ÂÂÂ637	
> ÂÂÂ638		rtc = devm_rtc_allocate_device(&client->dev);
> ÂÂÂ639		if (IS_ERR(rtc))
> ÂÂÂ640			return PTR_ERR(rtc);
> ÂÂÂ641	
> ÂÂÂ642		rtc->ops = &isl1208_rtc_ops;
> ÂÂÂ643	
> ÂÂÂ644		i2c_set_clientdata(client, rtc);
> ÂÂÂ645	
> ÂÂÂ646		rc = isl1208_i2c_get_sr(client);
> ÂÂÂ647		if (rc < 0) {
> ÂÂÂ648			dev_err(&client->dev, "reading status failed\n");
> ÂÂÂ649			return rc;
> ÂÂÂ650		}
> ÂÂÂ651	
> ÂÂÂ652		if (rc & ISL1208_REG_SR_RTCF)
> ÂÂÂ653			dev_warn(&client->dev, "rtc power failure detected, "
> ÂÂÂ654				Â"please set clock.\n");
> ÂÂÂ655	
> ÂÂÂ656		rc = sysfs_create_group(&client->dev.kobj, &isl1208_rtc_sysfs_files);
> ÂÂÂ657		if (rc)
> ÂÂÂ658			return rc;
> ÂÂÂ659	
> ÂÂÂ660		if (client->irq > 0) {
> ÂÂÂ661			rc = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> ÂÂÂ662						ÂÂÂÂÂÂÂisl1208_rtc_interrupt,
> ÂÂÂ663						ÂÂÂÂÂÂÂIRQF_SHARED | IRQF_ONESHOT,
> ÂÂÂ664						ÂÂÂÂÂÂÂisl1208_driver.driver.name,
> ÂÂÂ665						ÂÂÂÂÂÂÂclient);
> ÂÂÂ666			if (!rc) {
> ÂÂÂ667				device_init_wakeup(&client->dev, 1);
> ÂÂÂ668				enable_irq_wake(client->irq);
> ÂÂÂ669			} else {
> ÂÂÂ670				dev_err(&client->dev,
> ÂÂÂ671					"Unable to request irq %d, no alarm support\n",
> ÂÂÂ672					client->irq);
> ÂÂÂ673				client->irq = 0;
> ÂÂÂ674			}
> ÂÂÂ675		}
> ÂÂÂ676	
> Â> 677		return rtc_register_device(isl1208->rtc);
> Â> 678	}
> ÂÂÂ679	
> 
> ---
> 0-DAY kernel test infrastructureÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-allÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂIntel Corporation
Diehl AKO Stiftung & Co. KG, PfannerstraÃe 75-83, 88239 Wangen im AllgÃu
Bereichsvorstand: Dr.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied)
Sitz der Gesellschaft: Wangen i.A. â Registergericht: Amtsgericht Ulm HRA 620609 â PersÃnlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung â Sitz: NÃrnberg â Registergericht: Amtsgericht NÃrnberg HRA 11756 â
Vorstand: Dr.-Ing. E.h. Thomas Diehl (â) (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus GÃnther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier
___________________________________________________________________________________________________
Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.