Re: [PATCH 2/4] ARM: amba: Fix race condition with driver_override

From: Geert Uytterhoeven
Date: Mon Mar 05 2018 - 03:10:05 EST


Hi Todd,

On Fri, Mar 2, 2018 at 7:23 PM, Todd Kjos <tkjos@xxxxxxxxxxx> wrote:
> +stable
>
> what is the status of this patch? We'd like to get it into the android
> common branches to fix possible double free.

Thanks for your interest!

So far this patch (and the 3 others in the series) haven't received any
comments. If someone sends a Acked-by or Reviewed-by, I can submit them
to RMK's patch system.

Thanks!

> On Fri, Jan 19, 2018 at 7:24 AM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> The driver_override implementation is susceptible to a race condition
>> when different threads are reading vs storing a different driver
>> override. Add locking to avoid this race condition.
>>
>> Cfr. commits 6265539776a0810b ("driver core: platform: fix race
>> condition with driver_override") and 9561475db680f714 ("PCI: Fix race
>> condition with driver_override").
>>
>> Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device binding path 'driver_override'")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds