Re: [RFC/RFT][PATCH 1/7] time: tick-sched: Reorganize idle tick management code

From: Peter Zijlstra
Date: Mon Mar 05 2018 - 05:45:17 EST


On Sun, Mar 04, 2018 at 11:24:00PM +0100, Rafael J. Wysocki wrote:
> +/**
> + * tick_nohz_idle_prepare - prepare for entering idle on the current CPU.
> + *
> + * Called when we start the idle loop.
> + */
> +void tick_nohz_idle_prepare(void)
> +{
> + __tick_nohz_idle_prepare();
> +
> + local_irq_enable();
> +}

I really dislike the asymmetry in IRQ state you introduced here.
__tick_nohz_idle_prepare() disables IRQs. Must we do that?