Re: [PATCH v3] mmc: Export host capabilities to debugfs.

[Harish Jenny K N]

On Monday 05 March 2018 05:43 PM, Ulf Hansson wrote:
> On 5 March 2018 at 10:28, Harish Jenny K N <harish_kandiga@xxxxxxxxxx> wrote:
>> From: Abbas Raza <Abbas_Raza@xxxxxxxxxx>
>>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Abbas Raza <Abbas_Raza@xxxxxxxxxx>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@xxxxxxxxxx>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@xxxxxxxxxx>
>> ---
>>
>> Changes in v3:
>> - Removed typecasting of &host->caps to (u32 *)
>>
>> Changes in v2:
>> - Changed Author
>>
>>  drivers/mmc/core/debugfs.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
>> index c51e0c0..570c9e4 100644
>> --- a/drivers/mmc/core/debugfs.c
>> +++ b/drivers/mmc/core/debugfs.c
>> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>>
>>         card->debugfs_root = root;
>>
>> +       if (!debugfs_create_x32("host_caps", S_IRUSR, root, &host->caps))
>> +               goto err;
>> +
> This isn't the correct place to created the node(s). Please move this
> to mmc_add_host_debugfs().
>
> Moreover, I suggest you export both caps and caps2 in the same change,
> there is no need to have two changes for that - and finally name the
> nodes to "caps" and "caps2".

Addressed your review findings in v4 patch.

Thanks,
Harish Jenny K N