Re: [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips

[Wolfram Sang]

On Mon, Mar 05, 2018 at 04:55:56PM +0100, Peter Rosin wrote:
> On 2018-03-05 16:53, Wolfram Sang wrote:
> > 
> >> @@ -97,59 +98,83 @@ static const struct chip_desc chips[] = {
> >>  		.nchans = 2,
> >>  		.enable = 0x4,
> >>  		.muxtype = pca954x_ismux,
> >> +		.id = { .manufacturer_id = I2C_DEVICE_ID_NONE },
> > 
> > Can't we just leave this empty and add a NULL pointer check below when
> > testing for the device id?
> 
> Nope, it's not a pointer. I didn't think it should be, but maybe it
> should?

Nope, you are right. Thanks for the heads up!

Attachment: signature.asc
Description: PGP signature