Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

From: Jarkko Sakkinen
Date: Mon Mar 05 2018 - 12:59:38 EST


On Mon, Mar 05, 2018 at 01:09:09PM +0000, Winkler, Tomas wrote:
> > enum tpm_duration {
> > TPM_DURATION_DEFAULT = 2000,
> > TPM_DURATION_LONG = 300000,
> > };
> >
> How is this aligned with the spec PTP spec?

For TPM 2.0 that spec only partially defines durations for CCs and thus
our look up table is already kind "flakky". In a sense that the default
duration is upper limit for spec defined durations.

> > These would be both for TPM 1.2 and TPM 2.0. Instead of having table for
> > every ordinal there should be a small tables describing commands that
> > require long timeout.
>
> Yeah I didn't cover the 1.2.

I could probably help with TPM 1.2 changes if required.

/Jarkko