Re: [PATCH RFC v9 0/7] Introduce the STACKLEAK feature and a test for it

From: Dave Hansen
Date: Mon Mar 05 2018 - 14:42:13 EST


On 03/05/2018 11:34 AM, Kees Cook wrote:
> Boris, Andy, and Dave (Hansen), you've all looked at this; would you
> be willing to give an Ack on the x86 parts? (Though I do now see a new
> comment from Dave was just sent.) And if not, what changes would you
> like to see?

I think it could definitely use another cleanup and de-#ifdef'ing pass.
It seems to have inherited the style from the original code and it's a
bit more than we're used to in mainline.