Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

From: Dave Hansen
Date: Mon Mar 05 2018 - 16:31:13 EST


On 03/05/2018 01:14 PM, Khalid Aziz wrote:
> Are you suggesting that vma returned by find_vma() could be split or
> merged underneath me if I do not hold mmap_sem and thus make the flag
> check invalid? If so, that is a good point.

This part does make me think that this code hasn't been tested very
thoroughly. Could you describe the testing that you have done? For MPX
and protection keys, I added something to tools/testing/selftests/x86,
for instance.