Re: [PATCH v2] scsi: ufs-qcom: add number of lanes for Tx and Rx links

[Rob Herring]

On Tue, Feb 27, 2018 at 01:46:17PM +0800, Can Guo wrote:
> From: Gilad Broner <gbroner@xxxxxxxxxxxxxx>
> 
> Different platforms may have different number of lanes for the UFS Tx/Rx
> links. Add parameter to device tree specifying how many lanes should be
> configured for the UFS Tx/Rx links. And don't print err message for clocks
> that are optional, this leads to unnecessary confusion about failure.
> 
> Signed-off-by: Gilad Broner <gbroner@xxxxxxxxxxxxxx>
> Signed-off-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>
> ---
> 
> Changes since v1:
> 	- Change commit subject for better description.
> 	- Incorporated Rob's review comments to use lanes-tx and lanes-rx
> 	  to handle asymmetric Tx/Rx links.
> 
>  .../devicetree/bindings/ufs/ufshcd-pltfrm.txt      |  4 ++

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

>  drivers/scsi/ufs/ufs-qcom.c                        | 65 +++++++++++++---------
>  drivers/scsi/ufs/ufshcd.c                          | 29 ++++++++++
>  drivers/scsi/ufs/ufshcd.h                          |  5 ++
>  4 files changed, 78 insertions(+), 25 deletions(-)