Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

From: kbuild test robot
Date: Tue Mar 06 2018 - 00:39:14 EST

Hi Lina,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc4 next-20180306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Lina-Iyer/drivers-qcom-add-RPMH-communication-support/20180305-225623
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64

All error/warnings (new ones prefixed by >>):

In file included from include/trace/define_trace.h:96:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
drivers/soc/qcom/./trace-rpmh.h: In function 'trace_event_raw_event_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function '__assign_string'; did you mean '__assign_str'? [-Werror=implicit-function-declaration]
__assign_string(name, d->name);
^
include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use in this function); did you mean 'node'?
__assign_string(name, d->name);
^
include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
drivers/soc/qcom/./trace-rpmh.h:29:19: note: each undeclared identifier is reported only once for each function it appears in
__assign_string(name, d->name);
^
include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
drivers/soc/qcom/./trace-rpmh.h: In function 'trace_event_raw_event_rpmh_send_msg':
drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use in this function); did you mean 'node'?
__assign_string(name, d->name);
^
include/trace/trace_events.h:719:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
In file included from include/trace/define_trace.h:97:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use in this function); did you mean 'node'?
__assign_string(name, d->name);
^
include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_send_msg':
drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use in this function); did you mean 'node'?
__assign_string(name, d->name);
^
include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~~~~~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +29 drivers/soc/qcom/./trace-rpmh.h

16
17 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
18
19 TP_ARGS(d, r),
20
21 TP_STRUCT__entry(
22 __string(name, d->name)
23 __field(int, m)
24 __field(u32, addr)
25 __field(int, errno)
26 ),
27
> 28 TP_fast_assign(
> 29 __assign_string(name, d->name);
30 __entry->m = r->m;
31 __entry->addr = r->msg->payload[0].addr;
32 __entry->errno = r->err;
33 ),
34
35 TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
36 __get_str(name), __entry->m, __entry->addr, __entry->errno)
37 );
38
39 DEFINE_EVENT(rpmh_notify, rpmh_notify_irq,
40 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
41 TP_ARGS(d, r)
42 );
43
44 DEFINE_EVENT(rpmh_notify, rpmh_notify_tx_done,
45 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
46 TP_ARGS(d, r)
47 );
48
49
> 50 TRACE_EVENT(rpmh_send_msg,
51
52 TP_PROTO(struct rsc_drv *d, int m, int n, u32 h, struct tcs_cmd *c),
53
54 TP_ARGS(d, m, n, h, c),
55
56 TP_STRUCT__entry(
57 __string(name, d->name)
58 __field(int, m)
59 __field(int, n)
60 __field(u32, hdr)
61 __field(u32, addr)
62 __field(u32, data)
63 __field(bool, complete)
64 ),
65
66 TP_fast_assign(
> 67 __assign_string(name, d->name);
68 __entry->m = m;
69 __entry->n = n;
70 __entry->hdr = h;
71 __entry->addr = c->addr;
72 __entry->data = c->data;
73 __entry->complete = c->complete;
74 ),
75
76 TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
77 __get_str(name), __entry->m, __entry->n, __entry->hdr,
78 __entry->addr, __entry->data, __entry->complete)
79 );
80

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip