Re: [PATCH v4 15/38] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

[Enric Balletbo i Serra]

Hi Marek,

On 06/03/18 08:35, Marek Szyprowski wrote:
> Hi All,
> 
> This is the patch, which introduces the issue I've pointed here:
> 
> https://lists.freedesktop.org/archives/dri-devel/2018-March/167794.html
> 
> On 2018-03-05 23:23, Enric Balletbo i Serra wrote:
>> From: Lin Huang <hl@xxxxxxxxxxxxxx>
>>
>> When panel is shut down, we should make sure edp can be disabled to avoid
>> undefined behavior.
>>
>> Cc: StÃphane Marchesin <marcheu@xxxxxxxxxxxx>
>> Signed-off-by: Lin Huang <hl@xxxxxxxxxxxxxx>
>> Signed-off-by: zain wang <wzz@xxxxxxxxxxxxxx>
>> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
>> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
>> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
>> ---
>>
>> Â drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++++
>> Â 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> index 92fb9a072cb6..9b7d530ad24c 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> @@ -1160,6 +1160,12 @@ static int analogix_dp_set_bridge(struct
>> analogix_dp_device *dp)
>> Â ÂÂÂÂÂ pm_runtime_get_sync(dp->dev);
>> Â +ÂÂÂ ret = clk_prepare_enable(dp->clock);
>> +ÂÂÂ if (ret < 0) {
>> +ÂÂÂÂÂÂÂ DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);
>> +ÂÂÂÂÂÂÂ goto out_dp_clk_pre;
>> +ÂÂÂ }
>> +
>> ÂÂÂÂÂ if (dp->plat_data->power_on)
>> ÂÂÂÂÂÂÂÂÂ dp->plat_data->power_on(dp->plat_data);
>> Â @@ -1191,6 +1197,8 @@ static int analogix_dp_set_bridge(struct
>> analogix_dp_device *dp)
>> ÂÂÂÂÂ phy_power_off(dp->phy);
>> ÂÂÂÂÂ if (dp->plat_data->power_off)
>> ÂÂÂÂÂÂÂÂÂ dp->plat_data->power_off(dp->plat_data);
>> +ÂÂÂ clk_disable_unprepare(dp->clock);
>> +out_dp_clk_pre:
>> ÂÂÂÂÂ pm_runtime_put_sync(dp->dev);
>> Â ÂÂÂÂÂ return ret;
>> @@ -1234,10 +1242,13 @@ static void analogix_dp_bridge_disable(struct
>> drm_bridge *bridge)
>> Â ÂÂÂÂÂ disable_irq(dp->irq);
>> ÂÂÂÂÂ phy_power_off(dp->phy);
>> +ÂÂÂ analogix_dp_set_analog_power_down(dp, POWER_ALL, 1);
> 
> In case of Exynos DP, external PHY is used to power the DP block, so no
> register access should be performed after phy_power_off(). Please move
> analogix_dp_set_analog_power_down() before phy_power_off().
> 

Oh, sorry, I missed that change, I'll include in next version, but I will wait a
little bit more before send for if I receive feedback on the others patches.


>> Â ÂÂÂÂÂ if (dp->plat_data->power_off)
>> ÂÂÂÂÂÂÂÂÂ dp->plat_data->power_off(dp->plat_data);
>> Â +ÂÂÂ clk_disable_unprepare(dp->clock);
>> +
>> ÂÂÂÂÂ pm_runtime_put_sync(dp->dev);
>> Â ÂÂÂÂÂ ret = analogix_dp_prepare_panel(dp, false, true);
> 
> Best regards
Enric