Re: [RFC/RFT][PATCH v2 4/6] cpuidle: Return nohz hint from cpuidle_select()

From: Rafael J. Wysocki
Date: Tue Mar 06 2018 - 04:28:40 EST


Bummer. :-(

On Tue, Mar 6, 2018 at 10:05 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:

> + if (drv->states[idx].flags & CPUIDLE_FLAG_POLLING) {
> + *nohz_ret = false;
> + } else if (drv->states[idx].target_residency < TICK_USEC) {
> + /*
> + * Do not stop the tick if there is at least one more state
> + * within the tick period range that could be used if longer
> + * idle duration was predicted.
> + */
> + *nohz_ret = first_idx > idx &&
> + drv->states[first_idx].target_residency < TICK_USEC;

This is reversed, sent a wrong version of the patch.

I'll resend with this fixed shortly.