Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task

From: John Garry
Date: Tue Mar 06 2018 - 07:30:37 EST


On 06/03/2018 11:23, Hannes Reinecke wrote:
On 03/05/2018 03:48 PM, John Garry wrote:
From: Xiaofei Tan <tanxiaofei@xxxxxxxxxx>

The current 110ms expiry time is not long enough for the internal
abort task.

The reason is that the internal abort task could be blocked in HW
if the HW is retrying to set up link. The internal abort task will
be executed only when the retry process finished.

Hmm. That sounds weird.
I would have expected that a link retrain will force a device reset,
after which no tasks should be active on the target.
Consequently the succeeding abort task will be a no-op.
Care to clarify?


Hi Hannes,

It sounds like you're talking about TMF task abort, right? This patch is related to controller internal abort function.

Our HW supports internal abort, where any pending queued commands in the controller can be aborted, so they will not be executed. When a disk is removed or a nexus reset are times when we issue such a command.

Thanks very much,
John

Cheers,

Hannes