Re: [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards

From: Rob Herring
Date: Tue Mar 06 2018 - 08:26:52 EST


On Tue, Mar 6, 2018 at 2:07 AM, <patrice.chotard@xxxxxx> wrote:
> From: Patrice Chotard <patrice.chotard@xxxxxx>
>
> As serial interface is already specified into bootargs,
> stdout-path can be removed.

Wrong way around. stdout-path is preferred over using console in bootargs.

>
> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxx>
> ---
>
> v2: _ none
>
> arch/arm/boot/dts/stih407-b2120.dts | 1 -
> arch/arm/boot/dts/stih410-b2120.dts | 1 -
> arch/arm/boot/dts/stih410-b2260.dts | 1 -
> arch/arm/boot/dts/stih418-b2199.dts | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
> index 2c4d6033b448..074b4cd0ca89 100644
> --- a/arch/arm/boot/dts/stih407-b2120.dts
> +++ b/arch/arm/boot/dts/stih407-b2120.dts
> @@ -15,7 +15,6 @@
>
> chosen {
> bootargs = "console=serial0,115200 clk_ignore_unused";
> - stdout-path = &sbc_serial0;
> };
>
> memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
> index 5422850641e8..eae3050984d0 100644
> --- a/arch/arm/boot/dts/stih410-b2120.dts
> +++ b/arch/arm/boot/dts/stih410-b2120.dts
> @@ -15,7 +15,6 @@
>
> chosen {
> bootargs = "console=serial0,115200 clk_ignore_unused";
> - stdout-path = &sbc_serial0;
> };
>
> memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
> index ca347160e35d..c26e388bd1a4 100644
> --- a/arch/arm/boot/dts/stih410-b2260.dts
> +++ b/arch/arm/boot/dts/stih410-b2260.dts
> @@ -16,7 +16,6 @@
>
> chosen {
> bootargs = "console=serial1,115200 clk_ignore_unused";
> - stdout-path = &uart1;
> };
>
> memory@40000000 {
> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
> index dbf7bb704a1a..d948f774fee7 100644
> --- a/arch/arm/boot/dts/stih418-b2199.dts
> +++ b/arch/arm/boot/dts/stih418-b2199.dts
> @@ -15,7 +15,6 @@
>
> chosen {
> bootargs = "console=serial0,115200 clk_ignore_unused";
> - stdout-path = &sbc_serial0;
> };
>
> memory@40000000 {
> --
> 1.9.1
>