Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver

[Arnaldo Carvalho de Melo]

Em Tue, Mar 06, 2018 at 03:36:58PM +0800, Wang YanQing escreveu:
> On Thu, Feb 08, 2018 at 01:20:31PM +0100, Jiri Olsa wrote:
> > On Mon, Jan 15, 2018 at 12:47:32PM +0800, Wang YanQing wrote:
> > > So that beautifiers wanting to resolve kernel function addresses to
> > > names can do its work, and when we use "perf report" for output of
> > > "perf kmem record", we will get kernel symbol output.
> > > 
> > > Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> > 
> > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> 
> Hi! Arnaldo Carvalho de Melo
> 
> What is the status of this patch now?
> Does the patch sanked to the bottom of your mailbox?

It looks ok, but you forgot to add a before and after output of tools
affected by the patch.

Reading the patch one can try and figure out how to test your patch, but
if you show how the output is changed, providing the exact command line
used to produce the output, then you will make it easier for reviewers
to reproduce your results, testing your patch.

I try to do this for every patch, so it all adds up, please help me with
reviewing your patch :-)

- Arnaldo