Re: [RFC, PATCH 13/22] mm, rmap: Free encrypted pages once mapcount drops to zero

From: Kirill A. Shutemov
Date: Tue Mar 06 2018 - 10:01:23 EST


On Tue, Mar 06, 2018 at 06:59:04AM -0800, Dave Hansen wrote:
> On 03/06/2018 12:27 AM, Kirill A. Shutemov wrote:
> > + anon_vma = page_anon_vma(page);
> > + if (anon_vma_encrypted(anon_vma)) {
> > + int keyid = anon_vma_keyid(anon_vma);
> > + free_encrypt_page(page, keyid, compound_order(page));
> > + }
> > }
>
> So, just double-checking: free_encrypt_page() neither "frees and
> encrypts the page"" nor "free an encrypted page"?
>
> That seems a bit suboptimal. :)

Yes, I'm bad with words :)

--
Kirill A. Shutemov