Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

From: Lina Iyer
Date: Tue Mar 06 2018 - 17:05:49 EST


On Tue, Mar 06 2018 at 14:56 -0700, Lina Iyer wrote:
On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote:
On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot <lkp@xxxxxxxxx> wrote:

drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function '__assign_string'; did you mean '__assign_str'? [-Werror=implicit-function-declaration]

Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.

I compiled and checked for sparse. Didn't explictly test for this. Not
sure why it did not fail for me.

Duh. FTRACE seems to have been disabled. Will fix and update.

Thanks,
Lina