Re: [PATCH v2 2/2] dt-bindings: input: Add binding for RAVE SP input driver

From: Andrey Smirnov
Date: Tue Mar 06 2018 - 20:51:40 EST


On Tue, Mar 6, 2018 at 6:17 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Hi Andrey,
>
> On Thu, Mar 1, 2018 at 1:55 PM, Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:
> l
>> +++ b/Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.txt
>> @@ -0,0 +1,24 @@
>> +Zodiac Inflight Innovations RAVE Supervisory Processor Power Button Bindings
>> +
>> +RAVE SP input device is a "MFD cell" device corresponding to power
>> +button functionality of RAVE Supervisory Processor. It is expected
>> +that its Device Tree node is specified as a child of the node
>> +corresponding to the parent RAVE SP device (as documented in
>> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
>> +
>> +Required properties:
>> +
>> +- compatible: Should be "zii,rave-sp-pwrbutton"
>> +
>> +Example:
>> +
>> + rave-sp {
>> + compatible = "zii,rave-sp-rdu1";
>> + current-speed = <38400>;
>> +
>> + pwrbutton {
>> + compatible = "zii,rave-sp-pwrbutton";
>> + status = "okay";
>
> In the dts patch review Shawn said:
>
> "The okay status is to flip the state of devices that are initially
> disabled. I think it's unnecessary for the case here."
>
> so please remove the status line.

Sure, will do in v3.

Thanks,
Andrey Smirnov