RE: [PATCH v6] mmc: Export host capabilities to debugfs.

[Avri Altman]

> -----Original Message-----
> From: Harish Jenny K N [mailto:harish_kandiga@xxxxxxxxxx]
> Sent: Wednesday, March 07, 2018 7:38 AM
> To: ulf.hansson@xxxxxxxxxx; linus.walleij@xxxxxxxxxx;
> adrian.hunter@xxxxxxxxx; shawn.lin@xxxxxxxxxxxxxx; Avri Altman
> <Avri.Altman@xxxxxxx>; andriy.shevchenko@xxxxxxxxxxxxxxx
> Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> harish_kandiga@xxxxxxxxxx; Vladimir_Zapolskiy@xxxxxxxxxx
> Subject: [PATCH v6] mmc: Export host capabilities to debugfs.
> 
> This patch exports the host capabilities to debugfs
> 
> This idea of sharing host capabilities over debugfs came up from Abbas Raza
> <Abbas_Raza@xxxxxxxxxx> Earlier discussions:
> https://lkml.org/lkml/2018/3/5/357
> https://www.spinics.net/lists/linux-mmc/msg48219.html
> 
> Signed-off-by: Harish Jenny K N <harish_kandiga@xxxxxxxxxx>
> ---
> 
> 
> +static int mmc_caps_show(struct seq_file *s, void *unused) {
> +	struct mmc_host *host = s->private;
> +	u32 caps = host->caps;
> +
> +	seq_puts(s, "\nMMC Host capabilities are:\n");
> +	seq_puts(s,
> "=============================================\n");
> +	seq_printf(s, "Can the host do 4 bit transfers :\t%s\n",
> +		   ((caps & MMC_CAP_4_BIT_DATA) ? "Yes" : "No"));

Maybe use a more compact form, and just call a macro with the applicable (stringified) bit?


Thanks,
Avri