Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

[Dan Carpenter]

On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote:
> @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
>  	keyidx = pos[3];
>  	if (!(keyidx & (1 << 5))) {
>  		if (net_ratelimit()) {
> -			printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n",
> -				hdr->addr2);
> +			netdev_dbg(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n",
> +				   hdr->addr2);
>  		}

I'm sorry.  I really hate to do this to you...  But the right thing here
is to use net_dbg_ratelimited() but get rid of the if (net_ratelimit())
check.  So it looks like this:

	if (!(keyidx & (1 << 5))) {
		net_dbg_ratelimited(skb->dev,
				    "CCMP: received packet without ExtIV flag from %pM\n",
				    hdr->addr2);
	}

Sorry again, when I looked at it before I just replied what my fast
thinking lizard brain said instead of taking time to look at what I was
saying.


regards,
dan carpenter