Re: [PATCH 1/7] genalloc: track beginning of allocations
From: Igor Stoppa
Date: Wed Mar 07 2018 - 10:47:40 EST
On 07/03/18 16:48, Igor Stoppa wrote:
>
>
> On 06/03/18 15:19, Mike Rapoport wrote:
>> On Wed, Feb 28, 2018 at 10:06:14PM +0200, Igor Stoppa wrote:
[...]
>>> + * get_boundary() - verifies address, then measure length.
>>
>> There's some lack of consistency between the name and implementation and
>> the description.
>> It seems that it would be simpler to actually make it get_length() and
>> return the length of the allocation or nentries if the latter is smaller.
>> Then in gen_pool_free() there will be no need to recalculate nentries
>> again.
>
> There is an error in the documentation. I'll explain below.
Argh, I do not know why I came out with that.
Yes, your comment is correct. I've modified the function accordingly and
it is simpler.
I will post it in the next revision.
--
igor