Re: [PATCH v3 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops to late

[Lee Jones]

On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote:

> From: Joseph Lo <josephl@xxxxxxxxxx>
> 
> The cros_ec_i2c driver is still active after it had suspended or before it
> resumes. Besides that, it also tried to transfer data even after the I2C
> host had been suspended. This will lead the system to crash.
> 
> During the test, we also observe that the EC needs to be resumed earlier
> due to some status polling from the EC FW (e.g. battery status). So we
> move the PM ops to late stage to make it work normally.
> 
> Signed-off-by: Joseph Lo <josephl@xxxxxxxxxx>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> ---
> 
> Changes in v3:
> - [8/8] Add static to cros_ec_i2c_pm_ops.
> - [8/8] Add the Reviewed-by Andy Shevchenko.
> 
> Changes in v2:
> - [8/8] This patch is new in this series replacing [5/6] of v1.
> 
>  drivers/mfd/cros_ec_i2c.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog