Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

From: Lee Jones
Date: Wed Mar 07 2018 - 11:54:22 EST


On Wed, 07 Mar 2018, Mark Brown wrote:

> On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote:
>
> > so i sent this patch to fix that by using the of_node name to create
> > debugfs.
>
> > but later i found we have:
> > commit a430ab205d29e7d1537b220fcf989b8080d8267f
> > Author: Fabio Estevam <fabio.estevam@xxxxxxx>
> > Date: Mon Mar 5 15:52:09 2018 -0300
>
> > regmap: debugfs: Disambiguate dummy debugfs file name
>
> > which would fix that in another way by naming dummy0, dummy1, dummy2.
>
> > even if the issue is fixed, i wonder could we still have this patch to make
> > it more readable:
>
> Yes, like I say I think that's a good idea anyway - that sort of usage
> is the reason we've got the facility to set an explicit name.

Is that an Ack?

--
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog