Re: [PATCH 1/3] certs: define a trusted platform keyring

From: Nayna Jain
Date: Wed Mar 07 2018 - 12:49:10 EST




On 03/07/2018 09:33 PM, David Howells wrote:
Nayna Jain <nayna@xxxxxxxxxxxxxxxxxx> wrote:

+ key = key_create_or_update(make_key_ref(keyring, 1),
+ "asymmetric",
+ NULL,
+ p,
+ plen,
+ ((KEY_POS_ALL & ~KEY_POS_SETATTR) |
+ KEY_USR_VIEW | KEY_USR_READ),
+ KEY_ALLOC_NOT_IN_QUOTA |
+ KEY_ALLOC_BUILT_IN |
+ KEY_ALLOC_BYPASS_RESTRICTION);
There's no need to reindent here. Please line up all the arguments: either
push the first argument over onto the next line if you need to or line them
all up with the char after the opening bracket.

Thanks David for the feedback. I will post the v2 version with this fix. Are there any other changes ?

Thanks & Regards,
ÂÂ - Nayna


David