Re: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support
From: David Miller
Date: Wed Mar 07 2018 - 13:25:09 EST
From: Anders Roxell <anders.roxell@xxxxxxxxxx>
Date: Tue, 6 Mar 2018 16:10:04 +0100
> The reuseport_bpf_numa test case fails there's no numa support. The
> test shouldn't fail if there's no support it should be skipped with a
> pass.
>
> Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for bpf_get_numa_node_id")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
I don't know about this.
The test did not pass. So it should not be "skipped with a pass".
We were unable to run it at all, which means we don't know if it
would pass or fail. This means there is a third state besides
pass or fail which we must acknowledge and implement.