Re: [PATCH][RESEND] block: sed-opal: fix response string extraction

From: Scott Bauer
Date: Wed Mar 07 2018 - 18:10:43 EST


On Tue, Mar 06, 2018 at 04:23:24PM -0800, Derrick, Jonathan wrote:
> This looks correct.
>
> Adding my Ack unless Scott has objections
>
> Acked-by: Jonathan Derrick <jonathan.derrick@xxxxxxxxx>


Reviewed-by: Scott Bauer <scott.bauer@xxxxxxxxx>

Nice catch Jonas! Sorry you had to resend, my message filtering was a little
too agressive and this slipped through the cracks, that has been remediated.


>
> On Thu, 2018-03-01 at 14:26 +0100, Jonas Rabenstein wrote:
> > Tokens are prefixed by a variable length of bytes. If a bytestring is
> > not stored in an tiny or short atom, we have to skip more than one
> > byte
> > in order to have the actual bytes not prefixed by the bytes
> > describing
> > the actual length of the string.
> >
> > Signed-off-by: Jonas Rabenstein <jonas.rabenstein@xxxxxxxxxxxxxxxxxxx
> > n.de>
> > ---
> > block/sed-opal.c | 26 +++++++++++++++++++++++---
> > 1 file changed, 23 insertions(+), 3 deletions(-)