Re: [PATCH] thermal: of: Allow selection of thermal governor in DT

From: Viresh Kumar
Date: Wed Mar 07 2018 - 23:51:04 EST


On Wed, Mar 7, 2018 at 4:29 PM, Amit Kucheria <amit.kucheria@xxxxxxxxxx> wrote:
> Cpufreq/cpuidle are designed to control a single parameter while
> thermal framework is trying to mitigate heat from several disparate
> sources that are throttled in different ways. Besides, cpufreq/cpuidle
> have somewhat mature governors. Cpuidle has only one governor (for
> tickless) - menu governor, cpufreq has ondemand in mainline, replaced
> by interactive in android and hopefully soon both will be replaced by

Interactive and schedfreq are already removed from Android 4.4 and 4.9.
It used schedutil now.

> schedutil.
>
> Badly configured cpufreq/cpuidle/devfreq only leads to wasted power,
> while badly configured thermal zone leads to the loss of operation
> e.g. reboots, too hot to touch, etc.

I don't think such heat-ups will happen right during boot, where some
init.rc should
come up and change the governor.

Over that if we are worried about production images only, then what prevents us
to select the right default governor in the defconfig ? We shouldn't
be worried about
multi-platform kernels for production images.

--
viresh