Re: [RFC PATCH ghak21 3/4] audit: add refused symlink to audit_names

[Paul Moore]

On Thu, Mar 8, 2018 at 7:30 PM, Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Wed, Feb 14, 2018 at 11:18 AM, Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
>> Audit link denied events for symlinks had duplicate PATH records rather
>> than just updating the existing PATH record.  Update the symlink's PATH
>> record with the current dentry and inode information.
>>
>> See: https://github.com/linux-audit/audit-kernel/issues/21
>> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
>> ---
>>  fs/namei.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> Merged.

Scratch that, not merged, although only because I think we need to
refactor patch 4/4 and the refactoring can/should encompass this
patch.

See my comments on 4/4.

>> diff --git a/fs/namei.c b/fs/namei.c
>> index 9cc91fb..0edf133 100644
>> --- a/fs/namei.c
>> +++ b/fs/namei.c
>> @@ -945,6 +945,7 @@ static inline int may_follow_link(struct nameidata *nd)
>>         if (nd->flags & LOOKUP_RCU)
>>                 return -ECHILD;
>>
>> +       audit_inode(nd->name, nd->stack[0].link.dentry, 0);
>>         audit_log_link_denied("follow_link", &nd->stack[0].link);
>>         return -EACCES;
>>  }
>> --
>> 1.8.3.1

-- 
paul moore
www.paul-moore.com