Re: [PATCH v5 1/3] Input: gpio-keys - add support for wakeup event action

From: Andy Shevchenko
Date: Sat Mar 10 2018 - 13:32:47 EST


On Sat, Mar 10, 2018 at 8:15 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:

> + while (--i >= 0) {

Just in case

while (i--) {

is slightly better to read.

> + bdata = &ddata->data[i];
> + if (bdata->button->wakeup)
> + gpio_keys_button_disable_wakeup(bdata);
> + bdata->suspended = false;
> + }

--
With Best Regards,
Andy Shevchenko