Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

From: Thierry Reding
Date: Mon Mar 12 2018 - 03:04:47 EST


On Fri, Mar 09, 2018 at 09:33:06AM -0800, Stephen Boyd wrote:
> Quoting Thierry Reding (2018-03-08 06:44:37)
> > On Thu, Mar 01, 2018 at 04:33:29PM +0300, Dmitry Osipenko wrote:
> > > On 15.01.2018 13:56, Dmitry Osipenko wrote:
> > > > On 10.01.2018 16:59, Dmitry Osipenko wrote:
> > > >> Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks
> > > >> as critical.
> > > >>
> > > >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> > > >> Acked-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> > > >> ---
> > > >>
> > > >> Change log:
> > > >> v2: Fixed accidentally missed marking EMC as critical on Tegra30 and
> > > >> Tegra124. Switched to a use of common EMC gate definition on Tegra20
> > > >> and Tegra30.
> > > >>
> > > >> v3: Dropped marking PLL_P outputs as critical, because seems they are
> > > >> not so critical. Although, I still haven't got a definitive answer
> > > >> about what exact HW functions are affected by the fixed-clocks.
> > > >> Anyway it should be cleaner to correct the actual drivers.
> > > >
> > > > Stephen / Michael, would it be possible to schedule these patches for 4.16? My
> > > > T20 and T30 devices aren't working without the 'critical clocks' patch. Things
> > > > happen to work with the opensource u-boot, but not with the proprietary
> > > > bootloader. It's probably not a big deal that out-of-tree devices are broken,
> > > > although would be nice to have one problem less.
> > >
> > > Guys, is there anything I could do to get these patches in linux-next?
> >
> > I've picked these up into the for-4.17/clk branch in the Tegra tree. I
> > already have that branch for the MBIST patches which are a dependency
> > for the for-4.17/soc branch.
> >
> > Stephen, Mike, let me know if you have any objections to carrying these
> > in the Tegra tree.
> >
>
> Are you going to send us a PR at some point?

Yes, I was going to let the patches cook a little in linux-next and send
a PR by the end of the week. Does that sound okay?

Thierry

Attachment: signature.asc
Description: PGP signature