RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
From: Adam Thomson
Date: Mon Mar 12 2018 - 04:33:06 EST
On 09 March 2018 17:34, Greg Kroah-Hartman wrote:
> On Tue, Jan 02, 2018 at 03:50:48PM +0000, Adam Thomson wrote:
> > This patch set adds sink side support for the PPS feature introduced in the
> > USB PD 3.0 specification.
> >
> > The source PPS supply is represented using the Power Supply framework to provide
> > access and control APIs for dealing with it's operating voltage and current,
> > and switching between a standard PDO and PPS APDO operation. During standard
> PDO
> > operation the voltage and current is read-only, but for APDO PPS these are
> > writable as well to allow for control.
> >
> > It should be noted that the keepalive for PPS is not handled within TCPM. The
> > expectation is that the external user will be required to ensure re-requests
> > occur regularly to ensure PPS remains and the source does not hard reset.
>
> I've applied the first 3 patches now. Can you rebase and resend based
> on the feedback so far?
That's great. Thanks. Need to also rebase based on the patch
'Revert "typec: tcpm: Only request matching pdos"' as this impacts the APDO
selection logic. This is on my TODO list and will try and deal with it ASAP,
hopefully this week.