Re: [PATCH 1/4] perf/x86/intel: Add Tremont CPU PMU support

From: Ingo Molnar
Date: Mon Mar 12 2018 - 04:49:15 EST



* kan.liang@xxxxxxxxxxxxxxx <kan.liang@xxxxxxxxxxxxxxx> wrote:

> + /*TODO: test Adaptive PEBS, no extra implementation needed */
> + /*TODO: test PDIR fixed counter */
> + /* TODO: OFFCORE_RESPONSE mask updates for 10nm convered IDI */
> + /*TODO: implement topdown metrics, base metrics interface same as SNC */

Do you ever _read_ the comments you are writing?

NAK for this kind of inconsistent mess, and it's a repeat pattern - you really
need to submit cleaner patches!

Thanks,

Ingo