Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

[Hans de Goede]

Hi,

On 12-03-18 09:13, Heikki Krogerus wrote:
> On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote:
> > Hi all,
> >
> > On 09-03-18 18:53, Greg Kroah-Hartman wrote:
> > > On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote:
> > > > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > > >
> > > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain
> > > > lookup tables for describing connections and provide custom
> > > > API for handling them. This introduces a single generic
> > > > lookup table and API for the connections.
> > > >
> > > > The motivation for this commit is centralizing the
> > > > connection lookup, but the goal is to ultimately extract the
> > > > connection descriptions also from firmware by using the
> > > > fwnode_graph_* functions and other mechanisms that are
> > > > available.
> > > >
> > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > >
> > > Sorry for the delay, just now reviewing this patch...
> > >
> > > The content is fine (if not scary for the obvious reason of passing
> > > around 'struct device' of different bus types, but ok...), but the api
> > > naming is "rough":
> >
> > Heikki, I think it is best if you answer Greg's remarks. FWIW I'm
> > fine with the changes Greg proposes.
>
> Me too.
>
> > I currently have significantly less bandwidth for this due to
> > personal circumstances, so if a new version of this patch-set
> > is necessary it would be great if you (Heikki) can do a v7.
>
> Sure thing. I'll prepare the v7.

Great, thank you. Don't forget to squash in the 2 fixes from
fengguang.wu@xxxxxxxxx .

Regards,

Hans