Re: [PATCH] platform/x86: dell_smbios: Resolve dependency error on ACPI_WMI

[Darren Hart]

On Mon, Mar 12, 2018 at 11:23:20AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 11, 2018 at 2:28 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > Similarly to DCDBAS for DELL_SMBIOS_SMM, if DELL_SMBIOS_WMI is enabled,
> > DELL_SMBIOS becomes dependent on ACPI_WMI. Update the depends line to
> > prevent a configuration where DELL_SMBIOS=y and either backend
> > dependency =m. Update the comment accordingly.
> 
> > +# The DELL_SMBIOS driver depends on ACPI_WMI and/or DCDBAS if those
> > +# backends are selected. The "depends" line prevents a configuration
> > +# where DELL_SMBIOS=y while either of those dependencies =m.
> >  #
> >  config DELL_SMBIOS
> >         tristate "Dell SMBIOS driver"
> > -       depends on DCDBAS || DCDBAS=n
> > +       depends on (DCDBAS || DCDBAS=n) && (ACPI_WMI || ACPI_WMI=n)
> 
> A nit: Perhaps separate depends on line for those two?

Agreed, resending v2, will run through testing, and send to Linus by EOD
tomorrow.

-- 
Darren Hart
VMware Open Source Technology Center