Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support
From: David Woodhouse
Date: Tue Mar 13 2018 - 04:14:01 EST
On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote:
>
> -ÂÂÂÂÂÂÂ.sriov_configure = ena_sriov_configure,
> +#ifdef CONFIG_PCI_IOV
> +ÂÂÂÂÂÂÂ.sriov_configure = pci_sriov_configure_simple,
> +#endif
> Â};
I'd like to see that ifdef go away, as discussed. I agree that just
#define pci_sriov_configure_simple NULL
should suffice. As Christoph points out, it's not going to compile if
people try to just invoke it directly.
I'd also *really* like to see a way to enable this for PFs which don't
have (and don't need) a driver. We seem to have lost that along the
way.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature