Re: [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable

From: Peter Ujfalusi
Date: Tue Mar 13 2018 - 09:29:35 EST




On 2018-03-13 14:05, Arnd Bergmann wrote:
> We now get a warning after the 'dmadev' variable is no longer used:
>
> drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb':
> drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable 'dmadev' [-Werror=unused-variable]
>
> Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

> ---
> drivers/media/platform/omap/omap_vout_vrfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c b/drivers/media/platform/omap/omap_vout_vrfb.c
> index 72c0ac2cbf3d..1d8508237220 100644
> --- a/drivers/media/platform/omap/omap_vout_vrfb.c
> +++ b/drivers/media/platform/omap/omap_vout_vrfb.c
> @@ -236,7 +236,6 @@ int omap_vout_prepare_vrfb(struct omap_vout_device *vout,
> struct dma_async_tx_descriptor *tx;
> enum dma_ctrl_flags flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
> struct dma_chan *chan = vout->vrfb_dma_tx.chan;
> - struct dma_device *dmadev = chan->device;
> struct dma_interleaved_template *xt = vout->vrfb_dma_tx.xt;
> dma_cookie_t cookie;
> enum dma_status status;
>

- PÃter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki