Re: [PATCH 1/1] x86/platform/x86: Fix count of CHas on multi-pci-segment arches

From: Andy Shevchenko
Date: Tue Mar 13 2018 - 12:00:35 EST


On Tue, Mar 13, 2018 at 5:58 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, Mar 13, 2018 at 3:42 AM, Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
>
>> +#define SKX_CAPID6 0x9c

>> + pci_read_config_dword(dev, SKX_CAPID6, &val);

Moreover, this is too non-flexible. Can't you find a capability based
on CAP ID + offset?

--
With Best Regards,
Andy Shevchenko