Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

From: Bjorn Andersson
Date: Tue Mar 13 2018 - 13:25:51 EST


On Tue 13 Mar 09:44 PDT 2018, Thierry Escande wrote:

> Add binding document for serial bluetooth chips using Qualcomm protocol.
>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxx>

Looks good, just two minor things.

[..]
> +Required properties:
> +
> + - compatible: should contain one of the following:
> + * "qcom,qca6174-bt"
> +

You're missing the "susclk" clock.

> +Optional properties:
> +
> + - bt-disable-n-gpios: GPIO specifier, used to enable chip during probe

Is this really optional?

Regards,
Bjorn