Re: [PATCH v2 0/1] Open questions

[Jakob Unterwurzacher]

On 13.03.18 18:42, Dr. Philipp Tomsich wrote:
> > On 13 Mar 2018, at 18:40, Jakob Unterwurzacher <jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > > +    /* get the urb context */
> > > > +    if (WARN_ON(!context))
> > > > +        return;
> > >
> > > Can this happen?
> >
> > Not unless there is a bug in the code. But we want to get a message
> > before dereferencing a pointer.
>
> Why not use BUG_ON(!context)?

I believe BUG_ON kills the kernel - the intention was to get loud 
message, but we'd rather not crash the user's machine.

Best regards,
Jakob