Re: [PATCH] perf stat: Add support for s390 transaction counters

From: Thomas-Mich Richter
Date: Wed Mar 14 2018 - 04:35:04 EST


On 03/13/2018 04:23 AM, Andi Kleen wrote:
> Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx> writes:
>
>> Right now there is only hard coded support for x86.
>
> That's not true. There is support for generic transaction events in perf.
>
> As far as I can tell your events would map 1:1 to the generic tx-* events.
>
> -Andi
>

I might be wrong, but when I look at function add_default_attributes()
in file buildin-stat.c the string variables transaction_attrs
and transaction_limited_attrs are used when flag T is specified on command line:

/* Default events used for perf stat -T */
static const char *transaction_attrs = {
"task-clock,"
"{"
"instructions,"
"cycles,"
"cpu/cycles-t/,"
"cpu/tx-start/,"
"cpu/el-start/,"
"cpu/cycles-ct/"
"}"
};

These PMU events show up on my x86 notebook but no on the s390.
That's why I came to this conclusion. I have not tried other architectures.
--
Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
GeschÃftsfÃhrung: Dirk Wittkopp
Sitz der Gesellschaft: BÃblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294