Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

From: Richard Leitner
Date: Wed Mar 14 2018 - 07:46:37 EST



On 03/14/2018 11:48 AM, Greg KH wrote:
> On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote:
>> From: Richard Leitner <richard.leitner@xxxxxxxxxxx>
>>
>> Replace the hardcoded PCI vendor ID of Netlogic with a definition in
>> pci_ids.h
>
> Why? It's only being used in one file, so it should not be in
> pci_ids.h, right?

It's also used as PCI_VENDOR_NETLOGIC in arch/mips/netlogic/xlp/.

Should this be replaced with PCI_VENDOR_ID_NETLOGIC from pci_ids.h?

>
> thanks,
>
> greg k-h
>

thank you!

regards;Richard.L