Re: [tip:x86/pti] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels

[Josh Poimboeuf]

On Wed, Mar 14, 2018 at 02:39:43PM +0100, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> 
> > On Wed, Mar 14, 2018 at 05:28:01AM -0700, tip-bot for Andy Whitcroft wrote:
> > > Commit-ID:  a14bff131108faf50cc0cf864589fd71ee216c96
> > > Gitweb:     https://git.kernel.org/tip/a14bff131108faf50cc0cf864589fd71ee216c96
> > > Author:     Andy Whitcroft <apw@xxxxxxxxxxxxx>
> > > AuthorDate: Wed, 14 Mar 2018 11:24:27 +0000
> > > Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> > > CommitDate: Wed, 14 Mar 2018 13:24:31 +0100
> > > 
> > > x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels
> > > 
> > > In the following commit:
> > > 
> > >   9e0e3c5130e9 ("x86/speculation, objtool: Annotate indirect calls/jumps for objtool")
> > > 
> > > ... we added annotations for CALL_NOSPEC/JMP_NOSPEC on 64-bit x86 kernels,
> > > but we did not annotate the 32-bit path.
> > > 
> > > Annotate it similarly.
> > 
> > This patch has no effect because objtool only supports 64-bit kernels.
> 
> Yeah, indeed - but it's still a good change for completeness, right?

Yeah, it's fine.  Objtool won't use it, but I suppose it makes the code
less surprising and more consistent for humans.

-- 
Josh