Re: [PATCHv3 0/2] zsmalloc/zram: drop zram's max_zpage_size

From: Minchan Kim
Date: Wed Mar 14 2018 - 11:07:26 EST


On Wed, Mar 14, 2018 at 05:18:31PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> ZRAM's max_zpage_size is a bad thing. It forces zsmalloc to
> store normal objects as huge ones, which results in bigger zsmalloc
> memory usage. Drop it and use actual zsmalloc huge-class value when
> decide if the object is huge or not.
>
> v3:
> - add pool param to zs_huge_class_size() [Minchan]
>
> Sergey Senozhatsky (2):
> zsmalloc: introduce zs_huge_class_size() function
> zram: drop max_zpage_size and use zs_huge_class_size()

Both looks good to me.

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks.