Re: [PATCH] vgacon: fix function prototypes

[Greg KH]

On Sat, Mar 10, 2018 at 03:40:59AM -0300, Joao Moreira wrote:
> It is possible to indirectly invoke functions with prototypes that do not
> match those of the respectively used function pointers by using void types.
> Despite widely used as a feature for relaxing function invocation, this
> should be avoided when possible as it may prevent the use of heuristics
> such as prototype matching-based Control-Flow Integrity, which can be used
> to prevent ROP-based attacks.
> 
> Given the above, the current efforts to improve the Linux security, and the
> upcoming kernel support to compilers with CFI features, fix prototypes in
> vgacon console driver.
> 
> Another similar fix can be seen in [1].
> 
> [1] https://android-review.googlesource.com/c/kernel/common/+/602010
> 
> Signed-off-by: João Moreira <jmoreira@xxxxxxx>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> ---
>  drivers/video/console/vgacon.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

This fails the build :(

drivers/video/console/vgacon.c:1432:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .con_putcs = vgacon_putcs,
               ^~~~~~~~~~~~

What tree should this go to?  It doesn't apply at all to my tty tree,
which is where I thought it should go, so I tried a different one and
got this mess :(

confused,

greg k-h