Re: [PATCH v3 11/20] firmware: enable to force disable the fallback mechanism at run time

[Greg KH]

On Sat, Mar 10, 2018 at 06:14:52AM -0800, Luis R. Rodriguez wrote:
> You currently need four different kernel builds to test the firmware
> API fully. By adding a proc knob to force disable the fallback mechanism
> completely we are able to reduce the amount of kernels you need built
> to test the firmware API down to two.
> 
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> ---
>  drivers/base/firmware_loader/fallback.c       | 5 +++++
>  drivers/base/firmware_loader/fallback.h       | 4 ++++
>  drivers/base/firmware_loader/fallback_table.c | 9 +++++++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
> index 45cc40933a47..d6838e7ec00c 100644
> --- a/drivers/base/firmware_loader/fallback.c
> +++ b/drivers/base/firmware_loader/fallback.c
> @@ -643,6 +643,11 @@ static bool fw_force_sysfs_fallback(unsigned int opt_flags)
>  
>  static bool fw_run_sysfs_fallback(unsigned int opt_flags)
>  {
> +	if (fw_fallback_config.ignore_sysfs_fallback) {
> +		pr_info_once("Ignoring firmware sysfs fallback due to debugfs knob\n");

s/debugfs/sysctl/ right?