Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault
From: Kani, Toshi
Date: Wed Mar 14 2018 - 15:38:59 EST
On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote:
> On Tue, 13 Mar 2018, Toshi Kani wrote:
>
> > vmalloc_fault() sets user's pgd or p4d from the kernel page table.
> > Once it's set, all tables underneath are identical. There is no point
> > of following the same page table with two separate pointers and makes
> > sure they see the same with BUG().
> >
> > Remove the pointless checks in vmalloc_fault(). Also rename the kernel
> > pgd/p4d pointers to pgd_k/p4d_k so that their names are consistent in
> > the file.
>
> I have no idea to which branch this might apply. The first patch applies
> cleanly on linus head, but this one fails in hunk #2 on everything I
> tried. Can you please check?
Sorry for the trouble. The patches are based on linus head. I just tried
and they applied clean to me...
Thanks,
-Toshi