Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

[Wolfgang Grandegger]

Am 14.03.2018 um 20:07 schrieb Jakob Unterwurzacher:
> On 14.03.18 11:04, Wolfgang Grandegger wrote:
> > > > Â(000.000443)Â can0Â 20000034ÂÂ [8]Â 00 0C 00 00 00 00 78 00   
> > > > ERRORFRAME
> > > > ÂÂÂ controller-problem{rx-error-warning,tx-error-warning}
> > > > ÂÂÂ transceiver-status
> > > > ÂÂÂ no-acknowledgement-on-tx
> > > > ÂÂÂ error-counter-tx-rx{{120}{0}}
> > > > Â(000.000444)Â can0Â 20000034ÂÂ [8]Â 00 3C 00 00 00 00 80 00   
> > > > ERRORFRAME
> > > >     
> > > > controller-problem{rx-error-warning,tx-error-warning,rx-error-passive,tx-error-passive} 
> >
> >
> > Just,
> >
> > ÂÂÂÂÂÂ controller-problem{rx-error-passive,tx-error-passive} [...]
> >
> > Back to error active is missing!?
>
> That was indeed missing. We have fixed the missing back-to-error-active 
> in our firmware.
>
> Also, we no longer send the controller status in every error frame, but 
> only on state changes (see below) which seems to be how other drivers 
> are handling things.

Good, it would also be useful, if berr-reporting could be enabled by the 
firmware. This avoids a lot of traffic and load, especially if no cable 
is connected.

Wolfgang.